Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated commands to github actions #4701

Merged
merged 24 commits into from
Jun 18, 2024
Merged

Migrated commands to github actions #4701

merged 24 commits into from
Jun 18, 2024

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Jun 5, 2024 •
edited
Loading

Migrated commands individually to work as GitHub actions with a workflow_dispatch event.

This will not disable the command-bot yet, but it's the first step before disabling it.

Commands migrated

  • bench-all
  • bench-overhead
  • bench
  • fmt
  • update-ui

Also created an action that will inform users about the new documentation when they comment bot.

Created documentation

Created a detailed documentation on how to use this action. Found the documentation here.

@Bullrich Bullrich self-assigned this Jun 5, 2024
@Bullrich Bullrich added the T12-benchmarks This PR/Issue is related to benchmarking and weights. label Jun 5, 2024
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6402946

@Bullrich Bullrich mentioned this pull request Jun 10, 2024
Closed
@Bullrich Bullrich marked this pull request as ready for review June 17, 2024 13:42
@Bullrich Bullrich requested review from a team as code owners June 17, 2024 13:42
@Bullrich
Copy link
Contributor Author

PR is ready for review.

@paritytech/ci can you please guide me on what machine I can use to run the bench tasks? As the latest-ubuntu doesn't have enough capacity to run those heavy tasks.

@Bullrich Bullrich added R0-silent Changes should not be mentioned in any release notes and removed T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Jun 17, 2024
@Bullrich Bullrich changed the title [WIP] - Migrated commands to github actions Migrated commands to github actions Jun 17, 2024
@alvicsam
Copy link
Contributor

@Bullrich are these benches for weights? If not you can use arc-runners-polkadot-sdk-benchmark runners

@Bullrich
Copy link
Contributor Author

@Bullrich are these benches for weights? If not you can use arc-runners-polkadot-sdk-benchmark runners

This are for the weights, so I'm afraid we can't use arc-runners-polkadot-sdk-benchmark.

@alvicsam
Copy link
Contributor

The machines have the same specs, the only differences is that weights use persistent machines. I haven't added weights machines yet so you can test arc-runners-polkadot-sdk-benchmark for now

@Bullrich
Copy link
Contributor Author

The machines have the same specs, the only differences is that weights use persistent machines. I haven't added weights machines yet so you can test arc-runners-polkadot-sdk-benchmark for now

Thanks. I applied the machines for the bench jobs

alvicsam
alvicsam requested changes Jun 18, 2024
View reviewed changes
.github/workflows/command-update-ui.yml Outdated Show resolved Hide resolved
@Bullrich Bullrich requested a review from alvicsam June 18, 2024 08:28
Bullrich and others added 18 commits June 18, 2024 14:49
@Bullrich
added action which install dependencies
b0421b6
@Bullrich
updated readme
3b12706
@Bullrich
added sync command
05c16b6
@Bullrich
fixed error message
b6df8f3
@Bullrich
added command bench command
4be95a0
@Bullrich
prettified comments
864fc3c
@Bullrich
fixed invalid directories
0ca77fc
@Bullrich
added command bench-all
7f68829
@Bullrich
added documentation of bench-all
fb52b72
@Bullrich
added documentation for combinations with benchmark
061d804
@Bullrich
added command bench-overhead
e127f63
@Bullrich
updated readme with latest command
9373850
@Bullrich
added command to list
c8afc24
@Bullrich
added action to comment about using the new cmds
7b421e4
@Bullrich
updated machine to be benchmark compatible
e15d016 
Following @alvicsam's advice, I changed the machines to `arc-runners-polkadot-sdk-benchmark`
@Bullrich @alvicsam
changed machine to beefy
ff35404 
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
@Bullrich
removed command-sync
70fdfc7
@Bullrich @rzadp
Simplified steps
cd6abc4 
Co-authored-by: Przemek Rzad <przemek@parity.io>
@Bullrich Bullrich enabled auto-merge June 18, 2024 12:49
@Bullrich Bullrich added this pull request to the merge queue Jun 18, 2024
Merged via the queue into master with commit 6daa939 Jun 18, 2024
144 of 156 checks passed
@Bullrich Bullrich deleted the bullrich/cmd-action branch June 18, 2024 13:35
@Bullrich Bullrich mentioned this pull request Jun 18, 2024
Merged
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/command-bot-has-migrated-to-github-actions/8722/1

github-merge-queue bot pushed a commit that referenced this pull request Jul 12, 2024
@Bullrich
added sync command (#4818)
ebb1bb6 
Added the command sync. Follow up on #4701 

This PR is blocked until a new machine for the sync gets deployed.
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 13, 2024
@Bullrich @TomaszWaszczyk
added sync command (paritytech#4818)
0393e2b 
Added the command sync. Follow up on paritytech#4701 

This PR is blocked until a new machine for the sync gets deployed.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@Bullrich @alvicsam
@rzadp @TarekkMA
Migrated commands to github actions (paritytech#4701)
f077f59 
Migrated commands individually to work as GitHub actions with a
[`workflow_dispatch`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch)
event.

This will not disable the command-bot yet, but it's the first step
before disabling it.

### Commands migrated
- [x] bench-all
- [x] bench-overhead
- [x] bench
- [x] fmt
- [x] update-ui

Also created an action that will inform users about the new
documentation when they comment `bot`.

### Created documentation 
Created a detailed documentation on how to use this action. Found the
documentation
[here](https://github.com/paritytech/polkadot-sdk/blob/bullrich/cmd-action/.github/commands-readme.md).

---------

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Przemek Rzad <przemek@parity.io>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@Bullrich @TarekkMA
added sync command (paritytech#4818)
3c73beb 
Added the command sync. Follow up on paritytech#4701 

This PR is blocked until a new machine for the sync gets deployed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvicsam alvicsam alvicsam approved these changes

@rzadp rzadp rzadp approved these changes

@ggwpez ggwpez ggwpez approved these changes

@eskimor eskimor eskimor approved these changes

@mordamax mordamax mordamax approved these changes

@mutantcornholio mutantcornholio Awaiting requested review from mutantcornholio

@franciscoaguirre franciscoaguirre Awaiting requested review from franciscoaguirre

Assignees

@Bullrich Bullrich

Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Bullrich @paritytech-cicd-pr @alvicsam @Polkadot-Forum @mordamax @eskimor @ggwpez @rzadp